![]() ![]()
This needs some form of unit test to land. #Mozilla thunderbird email parser Patch#It's possible to just get rid of SetDisableItemsOnMailNewsUrlDocshells js will be disabled properly for mailnens urls in onLocationChanged.Īnyway, in the interest of not bothering the fragile assumptions here, this patch fixes setting js on urls of interest correctly in SetDisableItemsOnMailNewsUrlDocshells.Ĭomment on attachment 827135 Both places need to set on the same docshell (unknown why rootDocshell wasn't used). So the (some) docshell is js enabled in onLocationChange for http content, but the problem is it's not the same docshell as was js disabled in SetDisableItemsOnMailNewsUrlDocshells the first time, since it was derived with some frameloader business (and the reason isn't clear). In fact, mailnews uris are js disabled twice, once in SetDisableItemsOnMailNewsUrlDocshells and again in onLocationChange. Splinter Review The (a) docshell is always js disabled first, since for feeds a mailbox:// uri is loaded, and then loadURI is done after the web page pref is checked. One fix would be to get rid of this: which from the comment there is just "extra" protection. NsMsgContentPolicy::OnLocationChange - location is NOT nsIMsgMessageUrl setting allowjs=true NsMsgContentPolicy::SetDisableItemsOnMailNewsUrlDocshells => !msgURL: NsMsgContentPolicy::OnLocationChange - location is nsIMsgMessageUrl setting allowjs=false NsMsgContentPolicy::OnLocationChange: mailbox:///home/magnus/.thunderbird/oa2zpb8z.testing/Mail/Feeds/digitoday?number=2696 scriptEnabled=0 - rule to hide noscript content NOT added PresShell::Init: mailbox:///home/magnus/.thunderbird/oa2zpb9z.testing/Mail/Feeds/digitoday?number=2696 #Mozilla thunderbird email parser code#This is a test for one of the feeds i read - which displays some garbage code msgURL: mailbox:///home/magnus/.thunderbird/oa2zpb8z.testing/Mail/Feeds/digitoday?number=2696 I debugged this a bit, it's definitely nsMsgContentPolicy enabling of js being applied to late. Unlike messages (mail/news), they have scripting and plugins support enabled (in fact, both cannot be enabled for mail/news messages anymore so feeds are purposely special-cased). My voice is not authoritative here but I'd say that feeds should be displayed/rendered exactly like in a normal browser tab. > Are these pages supposed to have scripting enabled or scripting disabled? (In reply to Henri Sivonen (:hsivonen) from comment #20) #Mozilla thunderbird email parser update#TB responsibles should probably do the same (or update SUMO or whatever they're using nowadays). Good to know, thanks for checking! I'll add a Known Issue entry to the release notes of all affected SeaMonkey versions until this bug gets fixed. > a functioning workaround for the moment. ![]() > (/chrome/userContent.css) and then restarting Thunderbird is > adding 'noscript ' to the user CSS file #Mozilla thunderbird email parser plus#> Henri, I can acknowledge that resetting '' to 'true' plus (In reply to Alexander Kriegisch from comment #18) If it does, the parser should be run in the scripting enabled mode and the user agent style sheet should supply the CSS rule mentioned above. Reasonable rendering then relies on the user agent style sheet supplying aĭoes the feed view run scripts? If not, the correct fix is to run the parser in the "scripting disabled" mode. When scripting is enabled, the source between and becomes a text node. > it seems the child of NOSCRIPT tags is being parsed as text rather No, it really isn't, since the old parser code *will* go away! > Disabling HTML5 may be a viable option for Thunderbird users In general, it's a really bad idea to to flip the pref and not let me know why you needed to flip it. Yeah, that would have been a good idea earlier. > Does anyone have an idea how we can get some traction here, e.g. (In reply to Jens Hatlak (:InvisibleSmiley) from comment #11) ![]() Page should be rendered properly without showing HTML code. The top and right frame contain html code. Page from RSS feed isn't rendered properly when opened in TB. ![]() Open any post from that feed in either a new message window or a new tab. Pages from this feed are rendered just fine in both, TB 3.1.10, and FF 4.0.1.Īlso the page is rendered fine in TB5 when opening it in the message area.Ģ. Both, the top frame and the right frame contain html code. When opening any post from this feed in either a new tab or a new window, the I've subscribed to the RSS feed below (a German IT news site): ![]()
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |